[webkit-reviews] review denied: [Bug 37910] [DRT/Chromium] Import MockSpellCheck from Chromium : [Attachment 53936] Proposed patch (rev.2)

[bugzilla-daemon at webkit.org]

Shinichiro Hamaji <hamaji at chromium.org> has denied TAMURA, Kent
<tkent at chromium.org>'s request for review:
Bug 37910: [DRT/Chromium] Import MockSpellCheck from Chromium
https://bugs.webkit.org/show_bug.cgi?id=37910

Attachment 53936: Proposed patch (rev.2)
https://bugs.webkit.org/attachment.cgi?id=53936&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
> +using namespace std;

Do we still need this?

> +    // Convert to String because WebString doesn't have find*() functions.
> +    const String text16(text.data(), text.length());

Is text16 good naming? Also, the comment seems to be stale.

> +    const char wordCharacters[] =
"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz";

static const would be better. Also, I think we can use isalpha or something
instead of this.