[webkit-reviews] review granted: [Bug 37905] Rendering SVGs through img elements is slow : [Attachment 53909] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Simon Hausmann
<hausmann at webkit.org>'s request for review:
Bug 37905: Rendering SVGs through img elements is slow
https://bugs.webkit.org/show_bug.cgi?id=37905

Attachment 53909: Patch
https://bugs.webkit.org/attachment.cgi?id=53909&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>

> +    if (s.width() * s.height() < 1024*1024) {

I guess this is the why you dont pass the coding style. Space needed around the
*. That needs fixing.

> Image* cachedImage = svgAsCachedImage();

so svgAsCachedImage creates a cached representation and stores it internally?
Maybe use a better name.

Maybe you could merge the two lines:

182	    Image* cachedImage = svgAsCachedImage();
 183	     if (cachedImage) {

Apart from that looks good.