[webkit-reviews] review granted: [Bug 37056] LayoutTests/editing/selection/move-left-right.html is slow : [Attachment 52478] patch v0

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 20 19:13:16 PDT 2010


Shinichiro Hamaji <hamaji at chromium.org> has granted MORITA Hajime
<morrita at google.com>'s request for review:
Bug 37056: LayoutTests/editing/selection/move-left-right.html is slow
https://bugs.webkit.org/show_bug.cgi?id=37056

Attachment 52478: patch v0
https://bugs.webkit.org/attachment.cgi?id=52478&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
> The expectation contains storange y values, which is due to Bug 37016, 
> that is revealed by the change. But it is not bug of this test, nor bug of
the
> code that the test exercises.

Is it easy to fix Bug 37016? If so, I'd suggest fixing it first.

> -	       layoutTestController.dumpAsText();
> +	       if (window.layoutTestController)
> +		   layoutTestController.dumpAsText();

I think we usually put dumpAsText on the toplevel so we can call this even when
runTest isn't called.

Anyway, this looks good!


More information about the webkit-reviews mailing list