[webkit-reviews] review granted: [Bug 37903] Added missing #include "Lookup.h" in LUT source files. : [Attachment 53906] The patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Patrick R. Gansterer
<paroga at paroga.com>'s request for review:
Bug 37903: Added missing #include "Lookup.h" in LUT source files.
https://bugs.webkit.org/show_bug.cgi?id=37903

Attachment 53906: The patch
https://bugs.webkit.org/attachment.cgi?id=53906&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> Index: JavaScriptCore/runtime/ArrayPrototype.cpp
> ===================================================================
> --- JavaScriptCore/runtime/ArrayPrototype.cpp (revision 57939)
> +++ JavaScriptCore/runtime/ArrayPrototype.cpp (working copy)
> @@ -24,13 +24,13 @@
>  #include "config.h"
>  #include "ArrayPrototype.h"
>  
> -#include "CodeBlock.h"
>  #include "CachedCall.h"
> +#include "CodeBlock.h"
>  #include "Interpreter.h"
>  #include "JIT.h"
>  #include "JSStringBuilder.h"
> -#include "ObjectPrototype.h"
>  #include "Lookup.h"

Since ArrayPrototype.h already includes Lookup.h, I don't think
ArrayPrototype.cpp needs to include it at all.

But this is not an argument against the patch. The reason this does not affect
other builds is that most use AllInOneFile.cpp rather than compiling these
files separately.