[webkit-reviews] review requested: [Bug 37367] Make Generated V8 code adhere to webkit style : [Attachment 53901] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 20 15:58:32 PDT 2010


Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 37367: Make Generated V8 code adhere to webkit style
https://bugs.webkit.org/show_bug.cgi?id=37367

Attachment 53901: patch
https://bugs.webkit.org/attachment.cgi?id=53901&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
This also fixes a bunch of style violations the TestObj.idl doesn't trigger.  I
ran check-webkit-style over the entire generated bindings, and there now is
only a single violation (in V8DOMWindow.cpp), which would be non-trivial to
resolve and probably cause the script to become substantially less readable.


More information about the webkit-reviews mailing list