[webkit-reviews] review requested: [Bug 37820] Web Inspector: Aggregated time stats should be visible in Timeline record Popup : [Attachment 53880] [patch] second iteration.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 20 14:21:17 PDT 2010


Ilya Tikhonovsky <loislo at chromium.org> has asked  for review:
Bug 37820: Web Inspector: Aggregated time stats should be visible in Timeline
record Popup
https://bugs.webkit.org/show_bug.cgi?id=37820

Attachment 53880: [patch] second iteration.
https://bugs.webkit.org/attachment.cgi?id=53880&action=review

------- Additional Comments from Ilya Tikhonovsky <loislo at chromium.org>
has binary changes.
1) Legend boxes was added to the Aggregated Time row data in Popup;
2) three bars with different opacity are used for one record. Solid is for Self
Time, with opacity 0.6 for aggregated cpu time of the record and it's children
and with opacity 0.2 for duration; 
3) Duration property is changed. Now it is time between startTime and
lastChildEndTime (was time between start and end of real event);
4) Title of popup is fixed.


More information about the webkit-reviews mailing list