[webkit-reviews] review granted: [Bug 37878] Hook compositing layers together across iframes : [Attachment 53867] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 20 14:19:15 PDT 2010


mitz at webkit.org has granted Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 37878: Hook compositing layers together across iframes
https://bugs.webkit.org/show_bug.cgi?id=37878

Attachment 53867: Patch
https://bugs.webkit.org/attachment.cgi?id=53867&action=review

------- Additional Comments from mitz at webkit.org
> +	   (WebCore::RenderLayerCompositor::enableCompositingMode): Call out to
the RenderView when
> +	   the compositing mode changes, so that the parent document can
updates its compositing status.

Typo: “updates”

Like Chris said, the assertions in the to* methods should just use is*, not
awkward string compare.


More information about the webkit-reviews mailing list