[webkit-reviews] review granted: [Bug 19539] Nested <ul>s are mishandled when converted to <ol> using execCommand('insertorderedlist') : [Attachment 51262] reverted the change to editing/execCommand/create-list-from-range-selection.html

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 20 13:59:35 PDT 2010


Justin Garcia <justin.garcia at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 19539: Nested <ul>s are mishandled when converted to <ol> using
execCommand('insertorderedlist')
https://bugs.webkit.org/show_bug.cgi?id=19539

Attachment 51262: reverted the change to
editing/execCommand/create-list-from-range-selection.html
https://bugs.webkit.org/attachment.cgi?id=51262&action=review

------- Additional Comments from Justin Garcia <justin.garcia at apple.com>
> -	   if (nextList && previousList)
> +	   if (m_listElement) {
> +	       if (canMergeLists(previousList, m_listElement.get()))
> +		   mergeIdenticalElements(previousList, m_listElement.get());
> +	       if (canMergeLists(m_listElement.get(), nextList))
> +		   mergeIdenticalElements(m_listElement.get(), nextList);

Is m_listElement necessarily still valid if it and previousList got merged?


> -HTMLElement* outermostEnclosingList(Node* node)
> +HTMLElement* outermostEnclosingList(Node* node, Node* rootNode)

I would call this rootList.

r=me


More information about the webkit-reviews mailing list