[webkit-reviews] review denied: [Bug 37867] [Qt] Patches to upstream from Qt for 2.0 : [Attachment 53853] Build fix on Mac v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 20 12:12:16 PDT 2010


Tor Arne Vestbø <vestbo at webkit.org> has denied Jocelyn Turcotte
<jocelyn.turcotte at nokia.com>'s request for review:
Bug 37867: [Qt] Patches to upstream from Qt for 2.0
https://bugs.webkit.org/show_bug.cgi?id=37867

Attachment 53853: Build fix on Mac v2
https://bugs.webkit.org/attachment.cgi?id=53853&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>

> +# Output in JavaScriptCore/<config>
> +CONFIG(debug, debug|release): JAVASCRIPTCORE_DESTDIR = debug
> +CONFIG(release, debug|release): JAVASCRIPTCORE_DESTDIR = release
> +# Use different targets to prevent parallel builds file clashes on Mac
> +CONFIG(debug, debug|release): JAVASCRIPTCORE_TARGET = jscored
> +CONFIG(release, debug|release): JAVASCRIPTCORE_TARGET = jscore

Nit, please combine these into scoped blocks, let's try to avoid repeated
CONFIG(...) all over the place


More information about the webkit-reviews mailing list