[webkit-reviews] review granted: [Bug 37869] Move URopeImpl to its own .h/.cpp. : [Attachment 53843] The patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 37869: Move URopeImpl to its own .h/.cpp.
https://bugs.webkit.org/show_bug.cgi?id=37869

Attachment 53843: The patch
https://bugs.webkit.org/attachment.cgi?id=53843&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
+    bool isInvalid() { return (m_refCountAndFlags & s_refCountInvalid) ==
s_refCountInvalid; }

Let's reverse the meaning of this function, and call it "isStringImpl". And
also give an appropriate name to s_refCountInvalid.

r=me