[webkit-reviews] review requested: [Bug 37729] [Qt] QScriptValuePrivate class needs some cleanup. : [Attachment 53844] Fix v2

[bugzilla-daemon at webkit.org]

Jędrzej Nowacki <jedrzej.nowacki at nokia.com> has asked  for review:
Bug 37729: [Qt] QScriptValuePrivate class needs some cleanup.
https://bugs.webkit.org/show_bug.cgi?id=37729

Attachment 53844: Fix v2
https://bugs.webkit.org/attachment.cgi?id=53844&action=review

------- Additional Comments from Jędrzej Nowacki <jedrzej.nowacki at nokia.com>
(In reply to comment #2)
Changelog changed.

> I do not understand this get method? It gets the private of the engine? 
Yes and the class do not have to be a friend, In general the get method is used
for conversion between a public and a private class. In QtScript I decided to
separete a public implementation and a private implementation. Public
implementation is used only for converting to a private one. All real work is
done in a private implementation. The design adventage is that we can inline
nearby all methods in private imlementation and we do not waste time for
converting values inside private implementation. If you want I can describe it
in detail.

> I guess
> you use a kind of smart pointer inside it, couldn't the method to the data()
> internally in that method. The code is not easy readable.
You are right. It is done.