[webkit-reviews] review denied: [Bug 37853] Update EFL port to match recent API changes. : [Attachment 53835] Update EFL port to match recent API changes (without Plugins)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 20 10:11:56 PDT 2010


Adam Roben (aroben) <aroben at apple.com> has denied Gustavo Sverzut Barbieri
<barbieri at profusion.mobi>'s request for review:
Bug 37853: Update EFL port to match recent API changes.
https://bugs.webkit.org/show_bug.cgi?id=37853

Attachment 53835: Update EFL port to match recent API changes (without Plugins)
https://bugs.webkit.org/attachment.cgi?id=53835&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> Index: WebCore/ChangeLog
> +++ WebCore/platform/graphics/efl/ImageEfl.cpp	(working copy)
> @@ -28,8 +28,8 @@
>  
>  #include "config.h"
>  #include "Image.h"
> -
>  #include "BitmapImage.h"
> +#include "SharedBuffer.h"

You should leave in the blank line after Image.h.

Everything else looks fine, though.


More information about the webkit-reviews mailing list