[webkit-reviews] review requested: [Bug 37804] Image shadow doesn't work in Qt : [Attachment 53814] patch2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 20 07:18:03 PDT 2010


qi <qi.2.zhang at nokia.com> has asked  for review:
Bug 37804: Image shadow doesn't work in Qt
https://bugs.webkit.org/show_bug.cgi?id=37804

Attachment 53814: patch2
https://bugs.webkit.org/attachment.cgi?id=53814&action=review

------- Additional Comments from qi <qi.2.zhang at nokia.com>
Created a new patch based on Simon's comments.

1. I try to change the image pixel color, the orginal code (setpixel) come from
a qt example, it is not efficient.
2. Currently, I created a bitmap first then change the color table.

Appreciate Simon's comments.


More information about the webkit-reviews mailing list