[webkit-reviews] review granted: [Bug 30623] [GTK] Enable DOM clipboard and drag-and-drop access : [Attachment 53774] Slight reorganization of my earlier work
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 20 07:05:30 PDT 2010
Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 30623: [GTK] Enable DOM clipboard and drag-and-drop access
https://bugs.webkit.org/show_bug.cgi?id=30623
Attachment 53774: Slight reorganization of my earlier work
https://bugs.webkit.org/attachment.cgi?id=53774&action=review
------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
77 GtkClipboard* PasteboardHelper::getPrimarySelectionClipboard(Frame* frame)
const
78 {
79 return gtk_widget_get_clipboard(widgetFromFrame(frame),
GDK_SELECTION_PRIMARY);
80 }
Indentation is off here.
I love this patch. The move to WebCore makes lots of sense, the refactoring
rocks, and the usage of GClosure is very smart! We should do it elsewhere as
well (like in the GeoLocation stuff). Thanks!
More information about the webkit-reviews
mailing list