[webkit-reviews] review granted: [Bug 37850] check-webkit-style: Add __eq__ and __ne__ methods to DefaultStyleErrorHandler : [Attachment 53796] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 20 05:10:30 PDT 2010
Shinichiro Hamaji <hamaji at chromium.org> has granted review:
Bug 37850: check-webkit-style: Add __eq__ and __ne__ methods to
DefaultStyleErrorHandler
https://bugs.webkit.org/show_bug.cgi?id=37850
Attachment 53796: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=53796&action=review
------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Looks good.
> + def test_eq__true_return_value(self):
Maybe too many underscores after "eq"?
> + def test_eq__false_return_value(self):
Maybe too many underscores after "eq"?
More information about the webkit-reviews
mailing list