[webkit-reviews] review granted: [Bug 35320] SVGResourceFilter needs to be moved to under Renderers : [Attachment 53787] patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 35320: SVGResourceFilter needs to be moved to under Renderers
https://bugs.webkit.org/show_bug.cgi?id=35320

Attachment 53787: patch
https://bugs.webkit.org/attachment.cgi?id=53787&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Fantastic patch, moving in the right direction :-)
Still needs a follow-up patch to rework filter effect dumping, but we had
nothing before, so this is way better than trunk.

r=me, though a last little nitpick before landing:
> +    if (!filterData->boundaries.width() || !filterData->boundaries.height())

> +	   return false;
Please use if (filterData->boundaries.isEmpty()) here :-)

Jeez, what a patch, even larger then those I write ;-)