[webkit-reviews] review denied: [Bug 37748] Make Sheriffbot more inspirational : [Attachment 53780] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 20 01:06:00 PDT 2010


Eric Seidel <eric at webkit.org> has denied Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 37748: Make Sheriffbot more inspirational
https://bugs.webkit.org/show_bug.cgi?id=37748

Attachment 53780: Patch
https://bugs.webkit.org/attachment.cgi?id=53780&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Please add unicode to your test case.

Seems fetch_ should just call parse_ internally, no?  Then parse could be
_parse?

I'm surprised the convertEntities bit is needed.  I wonder where else we might
need that?

BeatufifulSoup is a subclass of BeautifulStoneSoup, no need to import
BeautifulStoneSoup just for HTML_ENTITIES.

regexp strings shoudl start with r"


More information about the webkit-reviews mailing list