[webkit-reviews] review granted: [Bug 37843] [DRT/Chromium] Fix some unexpected results of editing : [Attachment 53777] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 20 00:06:09 PDT 2010


Shinichiro Hamaji <hamaji at chromium.org> has granted TAMURA, Kent
<tkent at chromium.org>'s request for review:
Bug 37843: [DRT/Chromium] Fix some unexpected results of editing
https://bugs.webkit.org/show_bug.cgi?id=37843

Attachment 53777: Patch
https://bugs.webkit.org/attachment.cgi?id=53777&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Looks good!

Side note: the corresponding file seems to be
src/webkit/tools/test_shell/test_webview_delegate.cc in chromium's tree. We
have only one startContainer call in the chromium's code so this would be just
a typo.

By the way, I think it's nice to have this kind of info in ChangeLog. Could you
update the ChangeLog before you land?


More information about the webkit-reviews mailing list