[webkit-reviews] review granted: [Bug 37777] protocolHostAndPortEquals host check makes a wrong assumption : [Attachment 53639] Proposed fix: take URLs credential into account
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 19 23:13:32 PDT 2010
Alexey Proskuryakov <ap at webkit.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 37777: protocolHostAndPortEquals host check makes a wrong assumption
https://bugs.webkit.org/show_bug.cgi?id=37777
Attachment 53639: Proposed fix: take URLs credential into account
https://bugs.webkit.org/attachment.cgi?id=53639&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+ int lengthHostA = a.hostEnd() - hostStartA;
It's strange that the order of words is different in old and new variables,
"host start" vs. "length host".
r=me, good catch!
More information about the webkit-reviews
mailing list