[webkit-reviews] review granted: [Bug 37741] Clean up RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject : [Attachment 53770] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 37741: Clean up
RenderPart/RenderPartObject/RenderFrame/RenderEmbeddedObject
https://bugs.webkit.org/show_bug.cgi?id=37741

Attachment 53770: Patch
https://bugs.webkit.org/attachment.cgi?id=53770&action=review

------- Additional Comments from mitz at webkit.org
> +inline RenderFrameBase* toRenderFrameBase(RenderObject* object)
> +{
> +    ASSERT(!object || object->isRenderFrameBase());
> +    return static_cast<RenderFrameBase*>(object);
> +}

Typically there’s also a const version of these.

> +
> +// This will catch anyone doing an unnecessary cast.
> +void toRenderPart(const RenderFrameBase*);

This is should be toRenderFrameBase(const RenderFrameBase*)

r=me