[webkit-reviews] review granted: [Bug 37198] [Qt] Interrupting JavaScript is cumbersome when you use QtLaucher for testing or profiling. : [Attachment 52867] GUI option instead of command line argument

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Balazs Kelemen
<kb at inf.u-szeged.hu>'s request for review:
Bug 37198: [Qt] Interrupting JavaScript is cumbersome when you use QtLaucher
for testing or profiling.
https://bugs.webkit.org/show_bug.cgi?id=37198

Attachment 52867: GUI option instead of command line argument
https://bugs.webkit.org/attachment.cgi?id=52867&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r+, but I think you can remove

+    WebPage(QObject* parent = 0, bool interruptingJavaScriptEnabled = false);

as you don't seem to call the constructor with that argument.

I'm generally not a fan of boolean arguments that make the caller code harder
to read,