[webkit-reviews] review granted: [Bug 37782] new-run-webkit-tests: add a "dryrun" port that can be used to trace expectations on other platforms : [Attachment 53744] and yet again ...

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 19 17:15:16 PDT 2010


Adam Barth <abarth at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 37782: new-run-webkit-tests: add a "dryrun" port that can be used to trace
expectations on other platforms
https://bugs.webkit.org/show_bug.cgi?id=37782

Attachment 53744: and yet again ...
https://bugs.webkit.org/attachment.cgi?id=53744&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Nifty!

 58	    f = open(path, mode)
 59	    contents = f.read()
 60	    f.close()

This might leak a file handle when an exception is thrown.  Please use the
"with" construction.


More information about the webkit-reviews mailing list