[webkit-reviews] review granted: [Bug 37313] [Qt] Fix or remove the runtime flag for accelerated compositing. : [Attachment 53726] changed some names, and moved the chrome-client check to the settings-cache phase. it still works :)

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 37313: [Qt] Fix or remove the runtime flag for accelerated compositing.
https://bugs.webkit.org/show_bug.cgi?id=37313

Attachment 53726: changed some names, and moved the chrome-client check to the
settings-cache phase. it still works :)
https://bugs.webkit.org/attachment.cgi?id=53726&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> diff --git a/WebCore/page/ChromeClient.h b/WebCore/page/ChromeClient.h
> index b710c91..d47134d 100644
> --- a/WebCore/page/ChromeClient.h
> +++ b/WebCore/page/ChromeClient.h
> @@ -214,6 +214,9 @@ namespace WebCore {
>	   // Sets a flag to specify that the view needs to be updated, so we
need
>	   // to do an eager layout before the drawing.
>	   virtual void scheduleCompositingLayerSync() = 0;
> +	   // return whether or not the client can render the composited layer,

> +	   // regardless of the settings
> +	   virtual bool canRenderCompositedLayers() { return true; }

Rename to allowsAcceleratedCompositing(), and make it |const|.

> diff --git a/WebCore/rendering/RenderLayerCompositor.cpp
b/WebCore/rendering/RenderLayerCompositor.cpp
> index 9430613..2d707b3 100644
> --- a/WebCore/rendering/RenderLayerCompositor.cpp
> +++ b/WebCore/rendering/RenderLayerCompositor.cpp
> @@ -131,6 +131,15 @@ void
RenderLayerCompositor::cacheAcceleratedCompositingFlags()
>	   showRepaintCounter = settings->showRepaintCounter();
>      }
>  
> +    // we allow the chrome to override the settings, in case the page is
rendered
> +    // on a chrome that doesn't allow accelerated compositing

Sentence case, and terminating period please.

r=me with those changes.