[webkit-reviews] review granted: [Bug 37060] List item markers are not always updated after changes in the DOM : [Attachment 52999] Use render tree to find the enclosing list
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 19 16:13:30 PDT 2010
Darin Adler <darin at apple.com> has granted Jakub Wieczorek
<jwieczorek at webkit.org>'s request for review:
Bug 37060: List item markers are not always updated after changes in the DOM
https://bugs.webkit.org/show_bug.cgi?id=37060
Attachment 52999: Use render tree to find the enclosing list
https://bugs.webkit.org/attachment.cgi?id=52999&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
This change seems OK.
I think we should consider using the renderer itself to represent the list
rather than the renderer's node. Thus the return value would have a type of
RenderObject* rather than Node*.
I also think that the argument should be RenderListItem* rather than const
RenderListeItem*. I don't know why we made it const!
More information about the webkit-reviews
mailing list