[webkit-reviews] review granted: [Bug 37667] Active notifications tests where implemented : [Attachment 53693] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted John Gregg <johnnyg at google.com>'s
request for review:
Bug 37667: Active notifications tests where implemented
https://bugs.webkit.org/show_bug.cgi?id=37667

Attachment 53693: Patch
https://bugs.webkit.org/attachment.cgi?id=53693&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> Index: LayoutTests/ChangeLog
> ===================================================================
> --- LayoutTests/ChangeLog	(revision 57659)
> +++ LayoutTests/ChangeLog	(working copy)
> @@ -1,3 +1,29 @@
> +2010-04-15  John Gregg  <johnnyg at google.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Enable the notifications layout tests, but skip them on the ports
that don't
> +	   implement notifications.

Please add a bug link here.

btw, these lines are different from before " ---
LayoutTests/fast/notifications/notifications-without-permission.html  
(revision 57650)	(from
LayoutTests/fast/notifications/notifications-without-permission.html-disabled:5
7650)"

I'm pretty sure there wasn't a "from" in the previous patch. This clearly
indicates that you did svn mv.