[webkit-reviews] review denied: [Bug 37715] [chromium] crash when dragging images : [Attachment 53706] fix compile

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 19 13:33:41 PDT 2010


David Levin <levin at chromium.org> has denied Evan Stade <estade at chromium.org>'s
request for review:
Bug 37715: [chromium] crash when dragging images
https://bugs.webkit.org/show_bug.cgi?id=37715

Attachment 53706: fix compile
https://bugs.webkit.org/attachment.cgi?id=53706&action=review

------- Additional Comments from David Levin <levin at chromium.org>

> diff --git a/WebKit/chromium/tests/DragImageTest.cpp
b/WebKit/chromium/tests/DragImageTest.cpp
> +class TestImage : public Image {
> +public:
> +
> +    explicit TestImage(const IntSize& size)
> +	   : Image(0),
> +	     m_Size(size)

Two nits: m_size (instead of m_Size) and put the comma before the m_size
instead of on the previous line.

That's all though.


More information about the webkit-reviews mailing list