[webkit-reviews] review denied: [Bug 37759] [Qt] need an implementation of LayoutTestController::computedStyleIncludingVisitedInfo : [Attachment 53684] proposed patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied yi shen <yi.4.shen at nokia.com>'s
request for review:
Bug 37759: [Qt] need an implementation of
LayoutTestController::computedStyleIncludingVisitedInfo
https://bugs.webkit.org/show_bug.cgi?id=37759

Attachment 53684: proposed patch
https://bugs.webkit.org/attachment.cgi?id=53684&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>


> +void DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo(QWebFrame*
frame, const QString& id, QVariantMap& infoMap)

Most of the patch looks fine to me, but why not simply return the QVariantMap
as return value of the function instead of using an out argument?