[webkit-reviews] review denied: [Bug 37667] Active notifications tests where implemented : [Attachment 53470] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 19 11:01:03 PDT 2010


David Levin <levin at chromium.org> has denied John Gregg <johnnyg at google.com>'s
request for review:
Bug 37667: Active notifications tests where implemented
https://bugs.webkit.org/show_bug.cgi?id=37667

Attachment 53470: Patch
https://bugs.webkit.org/attachment.cgi?id=53470&action=review

------- Additional Comments from David Levin <levin at chromium.org>
It looks like you are changing some file names basically but you didn't use
"svn mv" which is preferred for a number of reasons (including history
preservation and better diff's (I think)).

So r- due to lack of use of svn mv.


More information about the webkit-reviews mailing list