[webkit-reviews] review requested: [Bug 37779] [GTK] Button and Entry font color doesn't respect the system's style : [Attachment 53663] A preliminary patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 19 02:27:20 PDT 2010


Olivier Tilloy <olivier at tilloy.net> has asked  for review:
Bug 37779: [GTK] Button and Entry font color doesn't respect the system's style
https://bugs.webkit.org/show_bug.cgi?id=37779

Attachment 53663: A preliminary patch
https://bugs.webkit.org/attachment.cgi?id=53663&action=review

------- Additional Comments from Olivier Tilloy <olivier at tilloy.net>
This is a preliminary patch that fixes the font color of buttons.
Unfortunately I could figure out how to extend the patch to text inputs and
areas, it looks like the code path is quite different. Any input/feedback is
welcome.

Please note that this patch breaks at least one layout test
(fast/forms/button-style-color.html). This is because the expected layout hard
codes the colors of the buttons, which is obviously going to break if such
colors depend on the current GTK style.


More information about the webkit-reviews mailing list