[webkit-reviews] review denied: [Bug 37716] WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.h does not compile with minimal cofigured Qt : [Attachment 53544] fix patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 18 21:32:58 PDT 2010


Laszlo Gombos <laszlo.1.gombos at nokia.com> has denied Chang Shu
<Chang.Shu at nokia.com>'s request for review:
Bug 37716: WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.h does not
compile with minimal cofigured Qt
https://bugs.webkit.org/show_bug.cgi?id=37716

Attachment 53544: fix patch
https://bugs.webkit.org/attachment.cgi?id=53544&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
This patch would be more future-proof and would work in more build setups if
test would check if QT_NO_SYSTEMTRAYICON is defined.

I would also prefer to guard "DEFINES += ENABLE_NOTIFICATIONS=1" statement.


More information about the webkit-reviews mailing list