[webkit-reviews] review granted: [Bug 37754] check-webkit-style: Create a class to encapsulate reading text files : [Attachment 53599] Proposed patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 18 18:26:41 PDT 2010


Shinichiro Hamaji <hamaji at chromium.org> has granted Chris Jerdonek
<cjerdonek at webkit.org>'s request for review:
Bug 37754: check-webkit-style: Create a class to encapsulate reading text files
https://bugs.webkit.org/show_bug.cgi?id=37754

Attachment 53599: Proposed patch 2
https://bugs.webkit.org/attachment.cgi?id=53599&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Looks good! Sorry for the latency. A few comments:

How about changing all single quotes to double quotes at this chance?

> +    class TestProcessor(ProcessorBase):

How about naming this as MockProcessor?


More information about the webkit-reviews mailing list