[webkit-reviews] review requested: [Bug 35607] Allow building smoothly on win32 and win64 using GCC : [Attachment 53630] WebCore patch for mingw-w64

[bugzilla-daemon at webkit.org]

vanboxem.ruben at gmail.com has asked  for review:
Bug 35607: Allow building smoothly on win32 and win64 using GCC
https://bugs.webkit.org/show_bug.cgi?id=35607

Attachment 53630: WebCore patch for mingw-w64
https://bugs.webkit.org/attachment.cgi?id=53630&action=review

------- Additional Comments from vanboxem.ruben at gmail.com
npapi.h: uint32 is not correct for lparam and wparam on WIN64 (see links
below). Nothing changes for existing 32-bit code or other platforms.
Arena.h: pointers need to be cast to 64-bit types, uintptr_t handles platform
and bitness differences nicely
TexStream.*: int64 needs to be used on all WIN64 platforms, not just msvc
PluginView.cpp: cast to LONG_PTR instead of LONG (see link below)
PluginViewWin.cpp: fix pointer casts (this change is now reflected in npapi.h)

MSDN:
(64-bit guidelines)
http://msdn.microsoft.com/en-us/library/aa384242%28v=VS.9%29.aspx
(LONG_PTR)
http://msdn.microsoft.com/en-us/library/aa383751%28VS.9%29.aspx
Intel (WPARAM, LPARAM, see point 5):
http://software.intel.com/en-us/articles/seven-steps-of-migrating-a-program-to-
a-64-bit-system/

I hope this is enough to convinve everyone :) Otherwise I'd be happy to
elaborate.