[webkit-reviews] review granted: [Bug 37717] Provide a way for clients to set session storage quota : [Attachment 53598] Patch with chromium fix take 2 - forgot WebKitTools last time.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 18 01:41:04 PDT 2010


Jeremy Orlow <jorlow at chromium.org> has granted Ada Chan <adachan at apple.com>'s
request for review:
Bug 37717: Provide a way for clients to set session storage quota
https://bugs.webkit.org/show_bug.cgi?id=37717

Attachment 53598: Patch with chromium fix take 2 - forgot WebKitTools last
time.
https://bugs.webkit.org/attachment.cgi?id=53598&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
This will still break Chromium since it consumes the API (even though it
completely compiles now).  Could you please leave the default constructor and
have it call the other one with noQuota?  In fact, you could even skip adding
the constructor that allows a quota to be passed in since we don't currently
have any plans to add it (and let someone working on Chromium change it if we
change our minds).  Thanks!


More information about the webkit-reviews mailing list