[webkit-reviews] review granted: [Bug 37664] Chromium: Add --chromium option to new-run-webkit-websocketserver : [Attachment 53456] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 17 13:32:05 PDT 2010


Adam Barth <abarth at webkit.org> has granted Fumitoshi Ukai <ukai at chromium.org>'s
request for review:
Bug 37664: Chromium: Add --chromium option to new-run-webkit-websocketserver
https://bugs.webkit.org/show_bug.cgi?id=37664

Attachment 53456: Patch
https://bugs.webkit.org/attachment.cgi?id=53456&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Ok...

+ if self._chromium and sys.platform in ('cygwin', 'win32'):

All of these lines are wrong.  Knowledge of chromium should be confined to the
chromium port classes.


More information about the webkit-reviews mailing list