[webkit-reviews] review denied: [Bug 37731] Integrate v8 testing utility with webkit tests : [Attachment 53571] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Yaar Schnitman <yaar at chromium.org>'s
request for review:
Bug 37731: Integrate v8 testing utility with webkit tests
https://bugs.webkit.org/show_bug.cgi?id=37731

Attachment 53571: Patch
https://bugs.webkit.org/attachment.cgi?id=53571&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
+ os.system(' '.join(cmd))

os.system is a dangerous API.  Please consider using popen or
webkitpy.common.system.executive.

+ webkitRoot = os.path.join(os.path.dirname(__file__), '..', '..')

This seems very fragile.  Please consider using checkout_root in
webkitpy.common.checkout.scm.

+ workDir = tempfile.mkdtemp()

I don't understand why we need a working temp directory.  Can't we just
generate the new output into a memory buffer?