[webkit-reviews] review requested: [Bug 37754] check-webkit-style: Create a class to encapsulate reading text files : [Attachment 53597] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Apr 17 10:55:26 PDT 2010
Chris Jerdonek <cjerdonek at webkit.org> has asked for review:
Bug 37754: check-webkit-style: Create a class to encapsulate reading text files
https://bugs.webkit.org/show_bug.cgi?id=37754
Attachment 53597: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=53597&action=review
------- Additional Comments from Chris Jerdonek <cjerdonek at webkit.org>
Rather than changing the working code incrementally, I decided to add the class
we'll be switching to as a whole, with more or less full unit test coverage. I
believe this will make the subsequent steps smaller and a bit easier to
understand -- since we'll just need to start using a class that already exists
and is fully tested. (I'm not sure the existing code actually tests reading
files anyways. I think it tests with mock methods in all cases.)
More information about the webkit-reviews
mailing list