[webkit-reviews] review denied: [Bug 37428] [Qt] Patch to fix compilation warnings for QGraphicsWebView : [Attachment 53355] Diff against trunk with ChangeLog

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Andreas Kling
<andreas.kling at nokia.com>'s request for review:
Bug 37428: [Qt] Patch to fix compilation warnings for QGraphicsWebView
https://bugs.webkit.org/show_bug.cgi?id=37428

Attachment 53355: Diff against trunk with ChangeLog
https://bugs.webkit.org/attachment.cgi?id=53355&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
> diff --git a/WebKit/qt/Api/qgraphicswebview.cpp
b/WebKit/qt/Api/qgraphicswebview.cpp
> index 919a10a..b3bcbe7 100644
> --- a/WebKit/qt/Api/qgraphicswebview.cpp
> +++ b/WebKit/qt/Api/qgraphicswebview.cpp
> @@ -647,9 +647,13 @@ QVariant QGraphicsWebView::itemChange(GraphicsItemChange
change, const QVariant&
>      case ItemCursorChange:
>	   return value;
>      case ItemCursorHasChanged:
> -	   QEvent event(QEvent::CursorChange);
> -	   QApplication::sendEvent(this, &event);
> -	   return value;
> +	   {
> +	       QEvent event(QEvent::CursorChange);
> +	       QApplication::sendEvent(this, &event);
> +	       return value;
> +	   }

Coding style wants the opening brace on the line preceeding the code block.
Only function definitions have braces on lines of their own.

Otherwise LGTM of course.