[webkit-reviews] review denied: [Bug 37717] Provide a way for clients to set session storage quota : [Attachment 53554] Patch to allow setting session storage quota

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 16 13:35:23 PDT 2010


Jeremy Orlow <jorlow at chromium.org> has denied Ada Chan <adachan at apple.com>'s
request for review:
Bug 37717: Provide a way for clients to set session storage quota
https://bugs.webkit.org/show_bug.cgi?id=37717

Attachment 53554: Patch to allow setting session storage quota
https://bugs.webkit.org/attachment.cgi?id=53554&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
Why should clients be able to set session storage quota?  If pages want to use
up all the memory, they can.  And that memory goes away when the page goes
away.  Are you scared about session storage being filled up and the user
navigating to other origins but not closing the tab/page/window (and thus it
stays used)?  I guess I could see that being a valid use case for this....but
either way, the "why" should probably be explained better in the change log. 
(The meat of the patch looks good tho.)


More information about the webkit-reviews mailing list