[webkit-reviews] review denied: [Bug 37686] Canvas strokeRect strokes rectangle whose dimensions are 0 when lineWidth > 1 : [Attachment 53506] Patch with test case

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 15 23:49:21 PDT 2010


Oliver Hunt <oliver at apple.com> has denied Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 37686: Canvas strokeRect strokes rectangle whose dimensions are 0 when
lineWidth > 1
https://bugs.webkit.org/show_bug.cgi?id=37686

Attachment 53506: Patch with test case
https://bugs.webkit.org/attachment.cgi?id=53506&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
I think it would be better to make validateRectForCanvas do the check as that
gets the validation in a single place that is used uniformly -- is there any
place this might have a bad impact?


More information about the webkit-reviews mailing list