[webkit-reviews] review denied: [Bug 37682] WebSocket crash when it receives bad header. : [Attachment 53487] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 15 17:39:39 PDT 2010


Alexey Proskuryakov <ap at webkit.org> has denied Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 37682: WebSocket crash when it receives bad header.
https://bugs.webkit.org/show_bug.cgi?id=37682

Attachment 53487: Patch
https://bugs.webkit.org/attachment.cgi?id=53487&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> I see. Make it to dump a string a hex codes.

To re-iterate, I think that it's not great. Ideally, the text should explain
what exactly is wrong with the header, and not just dump it in the face of the
developer. But it's not a big deal.

Marking r- for the "return p" issue.


More information about the webkit-reviews mailing list