[webkit-reviews] review granted: [Bug 36678] Support using FormData to send a sliced file via XHR. : [Attachment 53347] Proposed Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 15 13:46:18 PDT 2010
Dmitry Titov <dimich at chromium.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 36678: Support using FormData to send a sliced file via XHR.
https://bugs.webkit.org/show_bug.cgi?id=36678
Attachment 53347: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=53347&action=review
------- Additional Comments from Dmitry Titov <dimich at chromium.org>
r=me
tiny nit:
> diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
> + Move common functionalities to test sending FormData into a helper
file
s/functionalities/functionality/
Also, the style bot complained because the change happens around old code with
style violation in it. Perhaps it would be nice to have a separate patch to fix
the style of that code?
More information about the webkit-reviews
mailing list