[webkit-reviews] review canceled: [Bug 31482] Refactor DatabaseTracker.h and eliminate all #ifdefs : [Attachment 53399] patch #1: remove the dependency on OriginQuotaManager from DatabaseTracker.h

[bugzilla-daemon at webkit.org]

Dumitru Daniliuc <dumi at chromium.org> has canceled Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 31482: Refactor DatabaseTracker.h and eliminate all #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=31482

Attachment 53399:  patch #1: remove the dependency on OriginQuotaManager from
DatabaseTracker.h
https://bugs.webkit.org/attachment.cgi?id=53399&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
(In reply to comment #25)
> (From update of attachment 53399 [details])
> it looks like you still have the quotaManager lifetime bound to that of
> DatabaseTracker instead of just making it local static.

Oops, sorry, it should be fixed now.

> Also, which was the change that you made to fix the test borkage?

I changed DatabaseTracker::getMaxSizeForDatabase(). this method used to lock on
originQuotaManager(), and then it called quotaForOrigin(), which locked on
m_databaseGuard. All other methods lock on m_databaseGuard first and then on
originQuotaManager() (DatabaseTracker.h documents the lock ordering). So I
changed getMaxSizeForDatabase() acquire locks in the correct order, and
replaced quotaForOrigin() with quotaForOriginNoLock().