[webkit-reviews] review canceled: [Bug 37621] Chromium/mac: Image thumbnails don't work for indexed images : [Attachment 53382] Patch

[bugzilla-daemon at webkit.org]

Nico Weber <thakis at chromium.org> has canceled Nico Weber
<thakis at chromium.org>'s request for review:
Bug 37621: Chromium/mac: Image thumbnails don't work for indexed images
https://bugs.webkit.org/show_bug.cgi?id=37621

Attachment 53382: Patch
https://bugs.webkit.org/attachment.cgi?id=53382&action=review

------- Additional Comments from Nico Weber <thakis at chromium.org>
Did the RetainPtr thing and even the
CGColorSpaceCreateWithName(kCGColorSpaceGenericRGB) suggestion.

I didn't add a comment though, because just saying that createcontext doesn't
work with indexed images misses the point. We really want RGB here, and not
whatever weird color space the image might be in.

(Also, the WebKit way apparently is to do `svn annotate` and then look at
revision log/bug afaiu).