[webkit-reviews] review granted: [Bug 35915] [EFL] Add FrameLoaderClientEfl.{cpp, h} to WebKit/efl/WebCoreSupport : [Attachment 50298] Add FrameLoaderClientEfl to WK/efl/WebCoreSupport.

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Leandro Pereira
<leandro at profusion.mobi>'s request for review:
Bug 35915: [EFL] Add FrameLoaderClientEfl.{cpp,h} to WebKit/efl/WebCoreSupport
https://bugs.webkit.org/show_bug.cgi?id=35915

Attachment 50298: Add FrameLoaderClientEfl to WK/efl/WebCoreSupport.
https://bugs.webkit.org/attachment.cgi?id=50298&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
On the mobile you probably want to say Mobile Safari and not Safari in the UA.


> +PassRefPtr<Frame> FrameLoaderClientEfl::createFrame(const KURL& url, const
String& name, HTMLFrameOwnerElement* ownerElement,
> +						    const String& referrer,
bool allowsScrolling, int marginWidth, int marginHeight)

Please keep these method definitions on one line.

Apart from that, it looks fine as an initial commit.