[webkit-reviews] review canceled: [Bug 21945] <!-- comment> -- > should be recognized as valid comment. : [Attachment 52125] Proposed fix: Allow a white space (per XML definition) in comment ending declaration

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 15 07:28:03 PDT 2010


Julien Chaffraix <jchaffraix at webkit.org> has canceled Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 21945: <!-- comment> -- > should be recognized as valid comment.
https://bugs.webkit.org/show_bug.cgi?id=21945

Attachment 52125: Proposed fix: Allow a white space (per XML definition) in
comment ending declaration
https://bugs.webkit.org/attachment.cgi?id=52125&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
I got Alexey's unofficial OK about this patch.

I don't feel comfortable enough to share the isXMLWhiteSpace implementation as
the meaning is fine for the HTML tokenizer but may not be so clear for other
part of the code (the editing code for example). I will file a bug about this
as it is a good refactoring task.


More information about the webkit-reviews mailing list