[webkit-reviews] review denied: [Bug 37304] WebKit does not support jpeg qulaity in canvas.toDataURL : [Attachment 53155] Proposed patch - try to satisfy build bot

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 14 18:29:16 PDT 2010


George Staikos <staikos at kde.org> has denied Leo Yang
<leo.yang at torchmobile.com.cn>'s request for review:
Bug 37304: WebKit does not support jpeg qulaity in canvas.toDataURL
https://bugs.webkit.org/show_bug.cgi?id=37304

Attachment 53155: Proposed patch - try to satisfy build bot
https://bugs.webkit.org/attachment.cgi?id=53155&action=review

------- Additional Comments from George Staikos <staikos at kde.org>
Generally looks good, but fails on mac:
WebKit/WebKitBuild/Release/DerivedSources/WebCore/DOMHTMLCanvasElement.mm: In
function 'NSString* -[DOMHTMLCanvasElement toDataURL:](DOMHTMLCanvasElement*,
objc_selector*, NSString*)':
WebKit/WebKitBuild/Release/DerivedSources/WebCore/DOMHTMLCanvasElement.mm:73:
error: no matching function for call to
'WebCore::HTMLCanvasElement::toDataURL(NSString*&, WebCore::ExceptionCode&)'
WebKit/WebCore/dom/CanvasSurface.h:62: note: candidates are: WebCore::String
WebCore::CanvasSurface::toDataURL(const WebCore::String&, double,
WebCore::ExceptionCode&)


More information about the webkit-reviews mailing list