[webkit-reviews] review granted: [Bug 37600] Windows Bots should kill old processes : [Attachment 53358] Kill Old Processes

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 37600: Windows Bots should kill old processes
https://bugs.webkit.org/show_bug.cgi?id=37600

Attachment 53358: Kill Old Processes
https://bugs.webkit.org/attachment.cgi?id=53358&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> Index: WebKitTools/BuildSlaveSupport/kill-old-processes-win

How about win/kill-old-processes instead?

> +def main():
> +    os.system("taskkill /f /im DumpRenderTree.exe")
> +    os.system("taskkill /f /im DumpRenderTree_debug.exe")
> +    os.system("taskkill /f /im testapi.exe")
> +    os.system("taskkill /f /im testapi_debug.exe")
> +    os.system("taskkill /f /im svn.exe")
> +    os.system("taskkill /f /im httpd.exe")
> +    os.system("taskkill /f /im cl.exe")
> +    os.system("taskkill /f /im link.exe")
> +    os.system("taskkill /f /im midl.exe")
> +    os.system("taskkill /f /im devenv.exe")
> +    os.system("taskkill /f /im perl.exe")
> +    os.system("taskkill /f /im imagediff.exe")

Can we have an array of all the process names we want to kill, and then loop
over the array?

You should kill imagediff_debug.exe, jsc.exe, and jsc_debug.exe, too.

r=me