[webkit-reviews] review denied: [Bug 34730] [Qt] Null QObjects properties cause Segmentation Fault : [Attachment 52989] Fixed the reported patch problems

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Bruno Schmidt
<bruno.schmidt at gmail.com>'s request for review:
Bug 34730: [Qt] Null QObjects properties cause Segmentation Fault
https://bugs.webkit.org/show_bug.cgi?id=34730

Attachment 52989: Fixed the reported patch problems
https://bugs.webkit.org/attachment.cgi?id=52989&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>

> +	   QObjects exported to the QWebkit javascript with properties that are
a null "QObject*" cause Segmentation Fault.
> +
> +	   If an QObject is added to the javascript context and it contains
properties of the type QObject* with NULL value, calling the property causes
Segmentation Fault.
> +	   So now the code checks for objects which are null and threat them
accordingly:
> +	    * QtInstance::getClass() may return NULL
> +	    * QtInstance::stringValue(ExecState* exec) may return jsNull()
> +	    * QtInstance::booleanValue() may return false.
> +	    * convertQVariantToValue(...) QObjectStar conversion returns
jsNull() if obj is null

Can you please wrap the lines at 80-100 chars?

> +
> +	   [Qt] Null QObjects properties cause Segmentation Fault
> +	   https://bugs.webkit.org/show_bug.cgi?id=34730

This should be at the top.