[webkit-reviews] review denied: [Bug 37492] Add more Mailto: URL regression tests : [Attachment 53321] Patch 3 - good to go?
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Apr 14 09:49:15 PDT 2010
Adam Barth <abarth at webkit.org> has denied Jonathan Dixon <joth at chromium.org>'s
request for review:
Bug 37492: Add more Mailto: URL regression tests
https://bugs.webkit.org/show_bug.cgi?id=37492
Attachment 53321: Patch 3 - good to go?
https://bugs.webkit.org/attachment.cgi?id=53321&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
Looks good. One detail:
+// This test cannot be represented in JavaScript, as \0 is stripped before
execution
+// ["addr1\0addr2?foo", "addr1%00addr2?foo"],
You can actually do this test. The trick to to escape the \ because these
strings get evaled twice:
+// ["addr1\\\0addr2?foo", "addr1%00addr2?foo"],
More information about the webkit-reviews
mailing list