[webkit-reviews] review denied: [Bug 36317] [EFL] Add EFL-specific code to Widget.h : [Attachment 53328] Add EFL-specific code to Widget.h.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 14 09:11:33 PDT 2010


Eric Seidel <eric at webkit.org> has denied Leandro Pereira
<leandro at profusion.mobi>'s request for review:
Bug 36317: [EFL] Add EFL-specific code to Widget.h
https://bugs.webkit.org/show_bug.cgi?id=36317

Attachment 53328: Add EFL-specific code to Widget.h.
https://bugs.webkit.org/attachment.cgi?id=53328&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I have no idea why Hyatt r+'d this before.

Two reviewers have now suggested using WidgetEFL, and there has been no
explanation from teh author why we would not, neither in the bug nor the
ChangeLog.

Please update the ChangeLog to explain why this change is done this way, or fix
ti to use WidgetEFL (assuming that's the modern way to do this type of
change?).  #ifdefs here seem super-ugly.


More information about the webkit-reviews mailing list